Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Projects] The CSS code needs Refactoring #4395

Open
VishrutAggarwal opened this issue Jun 18, 2023 · 14 comments
Open

[Projects] The CSS code needs Refactoring #4395

VishrutAggarwal opened this issue Jun 18, 2023 · 14 comments
Assignees
@ankushbhardwaj408
Labels
issue/remind kind/chore Necessary task

Comments

@VishrutAggarwal
Copy link
Contributor

Current Behavior

Currently, the CSS code present in src\sections\Projects\Project-grid\projectGrid.style.js has the following issues:

  1. It is extremely messy and is difficult to modify without breaking other things.
  2. There are no fixed breakpoints and thus very difficult to understand where the code needs to be modified to get the desired result.

Due to this, it is very difficult for new contributors to make contribute to this section. Refactoring is required to organize the code and enable more contributors to fix any bugs found.

It also hinders correction of other bugs, for example: issue #4321 .

Desired Situation

Ideally the following things must be kept in mind while refactoring the code completely:

  1. There should be proper breakpoints defined.
  2. The code is written in mobile-first view and thus should follow it in the refactored code too.
  3. The code follows the site's UI design.
  4. Use dynamic units like rem, percentage, etc. than px. (Use of px unit should be done where necessary though)
  5. Use media query should be proper and defined.

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.
@VishrutAggarwal VishrutAggarwal added the kind/chore Necessary task label Jun 18, 2023
@manshul014
Copy link

Can i contribute to this?.

@Shivam-AfA
Copy link
Contributor

Go ahead @manshul014 🚀

@nihalpawar4
Copy link

can I also contribute to this issue

@vishalvivekm
Copy link
Member

can I also contribute to this issue

Hi @nihalpawar4 , Thanks for jumping in.
We follow FCFS for assigning the issues to contributors.
Let's find you some other good-first and help wanted issues to work on. Check out the link : https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A%22help+wanted%22+

@nihalpawar4
Copy link

can I also contribute to this issue

Hi @nihalpawar4 , Thanks for jumping in. We follow FCFS for assigning the issues to contributors. Let's find you some other good-first and help wanted issues to work on. Check out the link : https://github.com/issues?q=is%3Aopen+is%3Aissue+archived%3Afalse+org%3Alayer5io+org%3Ameshery+org%3Aservice-mesh-performance+org%3Aservice-mesh-patterns+label%3A%22help+wanted%22+

ok thanks for the information will checkout the above link.

@sudhanshutech
Copy link
Member

Any updates here @manshul014

@saaagarsingh
Copy link
Contributor

@manshul014 are you working on this? If not I would love to go ahead with it.

@vishalvivekm
Copy link
Member

Thank you @saaagarsingh . // @Modern-artist

@nihalpawar4
Copy link

all the best....

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@ankushbhardwaj408
Copy link
Member

Hi @abhijeetgauravm If this is a valid issue? I would like to work on this. Please assign it to me.

@abhijeetgauravm
Copy link
Contributor

there u go @ankushbhardwaj408

@ankushbhardwaj408 ankushbhardwaj408 mentioned this issue Oct 2, 2023
Closed
1 task
@ankushbhardwaj408
Copy link
Member

Hi @abhijeetgauravm please review this pr

ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 7, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
a410455 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 9, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
4e3bdd5 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 12, 2023
@ankushbhardwaj408
Merge branch 'master' into ankushbhardwaj408-layer5io#4395
770563a
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 15, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
992f71a 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 18, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
44d08e4 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 18, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
6808639 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 20, 2023
@ankushbhardwaj408
Merge branch 'layer5io:master' into ankushbhardwaj408-layer5io#4395
5dd5a29
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 23, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
e7307ea 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Oct 28, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
e208cdd 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Nov 4, 2023
@ankushbhardwaj408
Merge branch 'master' of https://github.com/layer5io/layer5 into anku…
2cd3d82 
…shbhardwaj408-layer5io#4395
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Nov 6, 2023
@ankushbhardwaj408
Merge branch 'master' into ankushbhardwaj408-layer5io#4395
1e47a6b
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Nov 13, 2023
@ankushbhardwaj408
Merge branch 'master' into ankushbhardwaj408-layer5io#4395
2cb627b
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Nov 14, 2023
@ankushbhardwaj408
Merge branch 'master' into ankushbhardwaj408-layer5io#4395
1e95871
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Dec 4, 2023
@ankushbhardwaj408
Merge branch 'master' into ankushbhardwaj408-layer5io#4395
039ab40
ankushbhardwaj408 added a commit to ankushbhardwaj408/layer5 that referenced this issue Dec 4, 2023
@ankushbhardwaj408
Merge branch 'layer5io:master' into ankushbhardwaj408-layer5io#4395
5caecfb
@psankhe28
Copy link

@VishrutAggarwal , is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankushbhardwaj408 ankushbhardwaj408

Labels
issue/remind kind/chore Necessary task
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor[CSS File] ankushbhardwaj408/layer5