-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor[CSS File] #4998
Refactor[CSS File] #4998
Conversation
Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
🚀 Preview for commit af855c3 at: https://651b07ce08cdb15f4883c1cc--layer5.netlify.app |
🚀 Preview for commit a410455 at: https://65214e64d8258573bd012da6--layer5.netlify.app |
Hey @ankushbhardwaj408 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes |
🚀 Preview for commit 4e3bdd5 at: https://6523e34f96234200a53fd801--layer5.netlify.app |
Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
Hi @abhijeetgauravm i have added the breakpoints to the theme folder. So now they can be used anywhere. |
🚀 Preview for commit 53faf5c at: https://65251731fb1dc4038b8f60bd--layer5.netlify.app |
🚀 Preview for commit 770563a at: https://6527fc10dbaa8e1cadcd27c2--layer5.netlify.app |
🚀 Preview for commit 992f71a at: https://652c18d3b9951d106291397f--layer5.netlify.app |
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1); | ||
padding: 0 2rem; | ||
padding-bottom: 5rem; | ||
font-size: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the specification of font-size here necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think so because I changed all the px to rem considering the font size as base, but I think nothing will change if we remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove, if not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thanks, @ankushbhardwaj408 |
🚀 Preview for commit 44d08e4 at: https://652f6af7104d2b5c31391fa0--layer5.netlify.app |
🚀 Preview for commit 6808639 at: https://652f88569936d96ac32a2efc--layer5.netlify.app |
🚀 Preview for commit 5dd5a29 at: https://6532055043a84e51c9f922e6--layer5.netlify.app |
Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
🚀 Preview for commit eebafc5 at: https://6532116ac9a309607e7169f3--layer5.netlify.app |
🚀 Preview for commit e7307ea at: https://6536433c12f69428a1f5dbe3--layer5.netlify.app |
🚀 Preview for commit e208cdd at: https://653cca01eb148861a79bbdbf--layer5.netlify.app |
🚀 Preview for commit 2cd3d82 at: https://6546139d7c28b7642b3bbeee--layer5.netlify.app |
🚀 Preview for commit 1e47a6b at: https://654936c7b65ad23c867e138c--layer5.netlify.app |
🚀 Preview for commit 2cb627b at: https://655252f410f0680700f332f4--layer5.netlify.app |
🚀 Preview for commit 1e95871 at: https://655381bb22d02b046bf63b36--layer5.netlify.app |
🚀 Preview for commit 039ab40 at: https://656d4e0619315a7dcf1c9391--layer5.netlify.app |
🚀 Preview for commit 5caecfb at: https://656da619cb669e397b5bbf39--layer5.netlify.app |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Seeing no activity on this issue , lets close this and open for other contributors. |
Description
This PR fixes #4395
Notes for Reviewers
Refactored the css file src\sections\Projects\Project-grid\projectGrid.style.js
Signed commits