Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In footer "Subscribe to out newsletter" doesn't position well at some screen size #5148

Closed
Raj100679 opened this issue Nov 22, 2023 · 16 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@Raj100679
Copy link

Description

In footer section, "Subscribe to our newsletter" input doesn't looks great at some screen sizes

Expected Behavior

Screenshots

Screenshot (128)
Screenshot (129)

Environment:

  • Host OS: Windows
  • Browser: Brave

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Raj100679 Raj100679 added the kind/bug Something isn't working label Nov 22, 2023
@Raj100679 Raj100679 changed the title In footer "Subscribe to out newsletter" doesn't positions well at some screen size In footer "Subscribe to out newsletter" doesn't position well at some screen size Nov 22, 2023
@Raj100679
Copy link
Author

@leecalcote @abhijeetgauravm @vishalvivekm Can you check if it s valid issue?

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Nov 22, 2023

@leecalcote @abhijeetgauravm @vishalvivekm Can you check if it s valid issue?

Yeah, @Raj100679, I can see a similar inconsistency on both Edge and Chrome browsers too. Would you like to address it?

@akashyeole
Copy link

hey can you please assign this to me @abhijeetgauravm ?

@Raj100679
Copy link
Author

Hey @abhijeetgauravm I am already working on one issue at meshery, You can assign @akashyeole

@Nasirahamad88
Copy link

This is not a big problem. When the devices width(1060-1199)px.

@Nasirahamad88
Copy link

In this width range, apply a top margin of 100px to resolve this issue.@abhijeetgauravm

@Nasirahamad88
Copy link

I solved this problem can you check?

@abhijeetgauravm
Copy link
Contributor

Hey @akashyeole, since there is already a PR open by @Nasirahamad88, could you please help in reviewing the PR and move it forward? Also, @Nasirahamad88, please refrain from creating direct PRs without getting assigned first.

@abhijeetgauravm
Copy link
Contributor

@akashyeole do you want to address this?

@Jat1nSood
Copy link
Contributor

Hi guys @abhijeetgauravm @, I saw the issue and I have one doubt that if "subscribe to our newsletter" and "Join our community" are same?

Like Here:

image image

If they are we can simply hide the latter for small screens..

@prabhjeevnijjar
Copy link
Contributor

Hi @abhijeetgauravm I have solved the issue locally would like your review.

I'd like to pick this issue if @akashyeole has no problem with it.

Regards / Prabhjeev

@abhijeetgauravm
Copy link
Contributor

Since there is no response from @akashyeole . Let it get assigned to you @prabhjeevnijjar

@abhijeetgauravm
Copy link
Contributor

Hi guys @abhijeetgauravm @, I saw the issue and I have one doubt that if "subscribe to our newsletter" and "Join our community" are same?

Like Here:

image image
If they are we can simply hide the latter for small screens..

Hey @Jat1nSood Let's discuss this on website call on Monday at 6:30 PM IST / 7 AM Central time!

prabhjeevnijjar added a commit to prabhjeevnijjar/layer5 that referenced this issue Dec 16, 2023
Signed-off-by: prabhjeevnijjar <prabhjeevnijjar@gmail.com>
@prabhjeevnijjar
Copy link
Contributor

@abhijeetgauravm When can we discuss on this ?

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Dec 21, 2023

@abhijeetgauravm When can we discuss on this ?

Let's discuss this on website call Monday at 6:30 PM IST / 7 AM Central time.

@Ashparshp
Copy link
Contributor

@abhijeetgauravm, @saurabh100ni The reported issue is resolved. Could you please review and close this duplicate?

Refer issue #3865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

8 participants