Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GetNightHawk Logo on Project Grid #1797

Merged
merged 2 commits into from Apr 19, 2021
Merged

Updated GetNightHawk Logo on Project Grid #1797

merged 2 commits into from Apr 19, 2021

Conversation

adithyaakrishna
Copy link
Member

@adithyaakrishna adithyaakrishna commented Apr 19, 2021 •
edited

Signed-off-by: Adithya Krishna aadithya794@gmail.com

Description

This PR fixes #1794
Updated GetNightHawk Logo at https://layer5.io/projects/

Notes for Reviewers
image

Signed commits

  • Yes, I signed my commits.

@adithyaakrishna
Updated GetNightHawk Logo on Project Grid
2097e61 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Copy link
Member Author

@vinayaksh42 Could you review this PR? 👀
Please do let me know if any changes are required :)

@vinayaksh42 vinayaksh42 self-requested a review April 19, 2021 12:39
@vinayaksh42
Copy link
Member

@vinayaksh42 Could you review this PR? 👀
Please do let me know if any changes are required :)

sure, waiting for the build preview.

@l5io
Copy link
Contributor

l5io commented Apr 19, 2021

🚀 Preview for commit 2097e61 at: https://607d7c2478459a3db798d189--layer5ng.netlify.app

@l5io
Copy link
Contributor

l5io commented Apr 19, 2021

🚀 Preview for commit 2097e61 at: https://607d7c134a11f6ba4b1008ad--layer5ng.netlify.app

@vinayaksh42
Copy link
Member

Looks great @adithyaakrishna

@Nikhil-Ladha
Copy link
Contributor

One thing, though can you confirm if we download the Getnighthawk asset from the brand page what do we get. If those are correct or not, currently I am on phone, otherwise I would have checked it.

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha Yes, All the assets are downloadable as .zip files

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Yes, All the assets are downloadable as .zip files

It was downloadable, anyways. What I am asking is if the assets inside the zip files are the correct one or not. Check that.

@adithyaakrishna
Copy link
Member Author

Ohhh, My Bad I hadn't read it properly, will check that 😶

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha Yes, They have the old ones still
image
Will update those too 💯

@Nikhil-Ladha
Copy link
Contributor

Nikhil-Ladha commented Apr 19, 2021 •
edited

If you can please delete the old ones, as well.
Also, make sure it doesn't break anything 😅

@adithyaakrishna
Copy link
Member Author

Yess, Will do that 😂

@adithyaakrishna
Updated Brand Files
892e5f7 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 19, 2021

🚀 Preview for commit 892e5f7 at: https://607d932aa4ca12d5ac773e33--layer5ng.netlify.app

@Nikhil-Ladha
Copy link
Contributor

You have replaced the files within zip, right and not created new ones?

@Nikhil-Ladha
Copy link
Contributor

Also, you haven't replaced the zip files inside the src/assets for getnighthawk.

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha the getnighthawk.zip under src/assets already had new files
I've replaced the brand-kit.zip which had all the assets and also inside static/brand

@Nikhil-Ladha Nikhil-Ladha merged commit 928f6d1 into layer5io:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikhil-Ladha Nikhil-Ladha Nikhil-Ladha approved these changes

@vinayaksh42 vinayaksh42 vinayaksh42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Project] Getnighthawk Logo update for Project Grid
4 participants
@adithyaakrishna @vinayaksh42 @l5io @Nikhil-Ladha