New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve scroll trigger #3951
Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
🚀 Preview for commit 34f0465 at: https://640df75fb7b8ed14113b3945--layer5.netlify.app |
This certainly feels like a behavior improvement. 👍 |
@Udit-takkar Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar The responsivenes for the animations has improved. I can see a width difference in the visualize section, and also bullet points. Please correct that.
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
done |
🚀 Preview for commit 46e1f87 at: https://640f17b3ee9aa17a02e709fb--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar I can still see the bullet points in the Visualize section.
Thanks for pushing on this, @Udit-takkar 🤙 |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Shivam-AfA tested everything now. everything should be working fine now |
🚀 Preview for commit 4b5d88a at: https://641435e90ff0ef20b27d937c--layer5.netlify.app |
🚀 Preview for commit 99b7f1b at: https://641568531e2900191feba6fa--layer5.netlify.app |
@Udit-takkar Please remove the use of gsap library for the mobile view in your new PR. I'm merging this assuming that you will also correct the ovelapping of slider dots in your new PR. |
Description
This PR fixes #
Notes for Reviewers
Signed commits