Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve scroll trigger #3951

Merged
merged 5 commits into from Mar 19, 2023
Merged

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Mar 12, 2023

Description

This PR fixes #

  • centers the images for large screen
  • improve name
  • no extra empty space inside the feature container

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Udit Takkar added 2 commits March 12, 2023 21:12
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@l5io
Copy link
Contributor

l5io commented Mar 12, 2023

🚀 Preview for commit 34f0465 at: https://640df75fb7b8ed14113b3945--layer5.netlify.app

@leecalcote
Copy link
Member

This certainly feels like a behavior improvement. 👍

@Chadha93
Copy link
Member

@Udit-takkar Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

Copy link
Contributor

@Shivam-AfA Shivam-AfA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udit-takkar The responsivenes for the animations has improved. I can see a width difference in the visualize section, and also bullet points. Please correct that.

image

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar
Copy link
Contributor Author

done

@l5io
Copy link
Contributor

l5io commented Mar 13, 2023

🚀 Preview for commit 46e1f87 at: https://640f17b3ee9aa17a02e709fb--layer5.netlify.app

Copy link
Contributor

@Shivam-AfA Shivam-AfA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udit-takkar I can still see the bullet points in the Visualize section.

@leecalcote
Copy link
Member

Thanks for pushing on this, @Udit-takkar 🤙

Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@Udit-takkar
Copy link
Contributor Author

@Shivam-AfA tested everything now. everything should be working fine now

@l5io
Copy link
Contributor

l5io commented Mar 17, 2023

🚀 Preview for commit 4b5d88a at: https://641435e90ff0ef20b27d937c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 18, 2023

🚀 Preview for commit 99b7f1b at: https://641568531e2900191feba6fa--layer5.netlify.app

@Shivam-AfA
Copy link
Contributor

@Udit-takkar Please remove the use of gsap library for the mobile view in your new PR. I'm merging this assuming that you will also correct the ovelapping of slider dots in your new PR.

image

@Shivam-AfA Shivam-AfA merged commit 94893cc into layer5io:master Mar 19, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants