Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3964 : changed hover color for disappearing table cells #3974

Merged
merged 1 commit into from Mar 20, 2023
Merged

Issue #3964 : changed hover color for disappearing table cells #3974

merged 1 commit into from Mar 20, 2023

Conversation

hirentimbadiya
Copy link
Member

Description
Changed hover color to rgb(180 , 180 , 180) for dark theme and rgb(80 , 80 , 80) for light theme.

This PR fixes #3964

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: heyhiru <hirentimbadiya74@gmail.com>
@hirentimbadiya
Copy link
Member Author

here is preview

Layer5.Events.Calendar.-.Google.Chrome.2023-03-19.19-03-48.mp4

@hirentimbadiya
Copy link
Member Author

can anyone review this PR ? @leecalcote , @Chadha93 , @Nikhil-Ladha

@l5io
Copy link
Contributor

l5io commented Mar 19, 2023

🚀 Preview for commit 3ac3460 at: https://64171556d057c94f43d8aa61--layer5.netlify.app

@hirentimbadiya hirentimbadiya changed the title Isuue #3964 : changed hover color for disappearing table cells Issue #3964 : changed hover color for disappearing table cells Mar 19, 2023
@Chadha93
Copy link
Member

@hirentimbadiya Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

@Nikhil-Ladha Nikhil-Ladha merged commit 8a1eda5 into layer5io:master Mar 20, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Disappearing table cells on hover in dark mode
4 participants