Change gif, video to .webp format to reduce network payload for meshery page #3978
Conversation
Signed-off-by: ayush_gitk <ayushsharmaa101@gmail.com>
|
🚀 Preview for commit d593b22 at: https://64183a3ad057c92d70d8addb--layer5.netlify.app |
Signed-off-by: ayush_gitk <ayushsharmaa101@gmail.com>
|
🚀 Preview for commit 0e380c2 at: https://641841ce65f5501fe720438b--layer5.netlify.app |
| @@ -47,7 +51,7 @@ const FeaturesSectionWrapper = styled.section` | |||
| transform: skew(0deg, 6deg); | |||
| padding: 0 1rem 3rem; | |||
| text-align: center; | |||
| h1, h2, p { | |||
| h1, h2, h3, p { | |||
There was a problem hiding this comment.
You have added h3 here but haven't used in index.js file
| @@ -82,7 +86,7 @@ const FeaturesSectionWrapper = styled.section` | |||
| margin: 4rem 0; | |||
| align-items: center; | |||
| } | |||
| h2, h4 { | |||
| h2, h4, h3 { | |||
There was a problem hiding this comment.
same case here in smp-section added h3 class to add styles but haven't used h3 in index.js file
| @@ -242,7 +246,7 @@ const FeaturesSectionWrapper = styled.section` | |||
| } | |||
|
|
|||
| .mesh-mngmnt { | |||
| h3 { | |||
| h4 { | |||
There was a problem hiding this comment.
I am not able to understand it you added h4 here but in index.js file it is still h3
There was a problem hiding this comment.
Thanks for pointing this out, @hirentimbadiya 👍
|
@ayushthe1 Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :) |
| @@ -4,7 +4,8 @@ import Button from "../../../reusecore/Button"; | |||
| import Slider from "react-slick"; | |||
| import "slick-carousel/slick/slick.css"; | |||
| import "slick-carousel/slick/slick-theme.css"; | |||
| import Slide1 from "../images/service mesh performance example.gif"; | |||
| import MeshVideoWebp from "../images/smp-example.webm"; | |||
There was a problem hiding this comment.
NIT: change the name to MeshVideoWebm
|
Merge conflicts... @ayushthe1 |
|
@ayushthe1 I'm adding this to the agenda, let's discuss this. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
Description
This PR replaces the gif & video to
.webpformat as they consume less network payload for meshery page.This is the network-payload currently :
This will be the network payload after merging this PR :
Notes for Reviewers
The changes must be verified on safari browser before merging this pr
Signed commits