Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessay negative margin from email div #4111

Closed
wants to merge 1 commit into from

Conversation

chiragchhabria2
Copy link

Description

This PR fixes #3865

Notes for Reviewers
Removed -7 margin from email div

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Chirag Chhabria <chiragchhabria68@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 20, 2023

🚀 Preview for commit bf61304 at: https://64412e5cd618d02449153530--layer5.netlify.app

@chiragchhabria2
Copy link
Author

@l5io Thank you!

@chiragchhabria2
Copy link
Author

What should I do about these issues?

@Shivam-AfA
Copy link
Contributor

@chiragchhabria2 Did you test this on Safari?

@chiragchhabria2
Copy link
Author

chiragchhabria2 commented Apr 24, 2023

@Shivam-AfA no I didn't. I checked the issue on chrome desktop and mobile view only.

@Shivam-AfA
Copy link
Contributor

@Shivam-AfA no I didn't. I checked the issue on chrome desktop and mobile view only.

@chiragchhabria2 This issue is only reproducible on Safari, as mentioned by @Nikhil-Ladha. Do you see the same issue on chrome as well?

@chiragchhabria2
Copy link
Author

@Shivam-AfA no I didn't. I checked the issue on chrome desktop and mobile view only.

@chiragchhabria2 This issue is only reproducible on Safari, as mentioned by @Nikhil-Ladha. Do you see the same issue on chrome as well?

Yes I did see same issue even in chrome if you zoom in 150% or more

@Shivam-AfA
Copy link
Contributor

@chiragchhabria2 That's not the case for me. Maybe you can present this issue and the solution on today's website call?

@chiragchhabria2
Copy link
Author

@chiragchhabria2 That's not the case for me. Maybe you can present this issue and the solution on today's website call?

What's a website call? And how do I attend it?

@Shivam-AfA
Copy link
Contributor

What's a website call? And how do I attend it?

@chiragchhabria2 The website's call takes place every Monday at 5:30 pm IST. Contributors present what they've been working on and ask for feedback. The link to the call is https://meet.layer5.io/websites. Please add this as an agenda item in the meeting minutes and let's get the final feedback from the community.

@chiragchhabria2
Copy link
Author

@Shivam-AfA
here are screenshots of issue , I have taken these directly from layer5.io in chrome :
screenshots
here are screenshots from live preview of my commit
preview screenshots

@chiragchhabria2
Copy link
Author

Hey @Shivam-AfA did you see those screenshots?

@Shivam-AfA
Copy link
Contributor

Hey @chiragchhabria2. Thanks for sharing the demos. Please present this issue and solution on Monday's website call, if you would. Join the slack community here: https://layer5io.slack.com

@chiragchhabria2
Copy link
Author

chiragchhabria2 commented May 13, 2023

I won't be able to I have my classes. But I can do it on Thursday's call

@Chadha93
Copy link
Member

@chiragchhabria2 Seeing no activity here, let's close this issue. Feel free to reopen it, if you wish to continue.

@Chadha93 Chadha93 closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Footer] Subscribe component overlaps on zoom greater than 100%
5 participants