New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a form in index.mdx #4278
Conversation
<Col lg={5} md={6} sm={12} style={{ padding: "0" }}> | ||
<CommonForm | ||
title="Get the Book" | ||
form="The Enterprise path to service mesh Architectures 2nd Edition" | ||
account_desc="Send the The Enterprise path to service mesh Architectures 2nd Edition book in the Mail." | ||
submit_title="You will get book soon in the mail!" | ||
submit_body="Please patiently await for The Enterprise path to service mesh Architectures 2nd Edition Book." | ||
/> | ||
</Col> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Col lg={5} md={6} sm={12} style={{ padding: "0" }}> | |
<CommonForm | |
title="Get the Book" | |
form="The Enterprise path to service mesh Architectures 2nd Edition" | |
account_desc="Send the The Enterprise path to service mesh Architectures 2nd Edition book in the Mail." | |
submit_title="You will get book soon in the mail!" | |
submit_body="Please patiently await for The Enterprise path to service mesh Architectures 2nd Edition Book." | |
/> | |
</Col> | |
<Col lg={5} md={6} sm={12} style={{ padding: "0" }}> | |
<CommonForm | |
title="Get the Book" | |
form="epsma-book" | |
account_desc="Email the The Enterprise Path to Service Mesh Architectures 2nd Edition" | |
submit_title="Your copy of the book will arrive in your mailbox shortly." | |
submit_body="While waiting for your copy to arrive take a free learning path - https://layer5.io/learn/learning-path" | |
/> | |
</Col> |
Thanks, @Deepak-Choudhary0 |
🚀 Preview for commit 0d00df7 at: https://646dfec62d81770c35b5f18d--layer5.netlify.app |
Hey lee any update on link? like even if you click on image of the book it leave you at another link. |
🚀 Preview for commit 168e038 at: https://646e1a819244ec05242d4f60--layer5.netlify.app |
@Deepak-Choudhary0, yes, you can remove the external link completely. 👍 |
Done any other review?? |
Please make this a clickable |
The form action isn't invoking the necessary webhook to handle submission on the server-side. |
🚀 Preview for commit 8276b44 at: https://646eefeaedf95673549e8c14--layer5.netlify.app |
🚀 Preview for commit 4a03c2f at: https://646f42f90283630986d6fe1b--layer5.netlify.app |
|
I did not know about this one can you tell me someone who can help me about server side webhook? |
@Deepak-Choudhary0 Let's discuss this on websites call, add this as an agenda in meeting minutes if you would. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've handled all the server-side changes. // @Deepak-Choudhary0 |
Also switching CTA from Docker Extension to Playground or MeshMap might be good. 🤔 |
Yeah sure, that's where i am working. |
@Deepak-Choudhary0 Updates? |
I will show it on Monday meetings as i have done the output(the confirmation message) part styling , just the input form needs to be corrected too. |
Well this could be resolved by changing Recording.2023-06-11.003858.mp4 |
Please add this as an agenda item in the meeting minutes @Deepak-Choudhary0 |
|
Im saying after when we click submit button , because the issue arises when we submit the form. |
@Deepak-Choudhary0 updates? |
hey @Ghat0tkach do you have anything in mind how we can do that float:none when user clicks on submit , mine mind is blank. |
@Deepak-Choudhary0 , Mine approach is simple , we have to use two functions one for submitting email to backend and another is to making float to none. We can use
|
@Ghat0tkach how will we trigger this, because in commonform component there is no prop to handle like onclick,onsuccess to trigger this function |
@Deepak-Choudhary0 Maybe you can check if "thank-you-box" class is rendering/visible and then append the |
yeah @Savio629 but i am not getting how will i implement this function such that when "ThankYouBox" renders after user successfully registers for book email , the "Book" class should be made float:none |
Let's discuss this on websites call. Please add this as an agenda item in the meeting minutes if you would :) |
@Deepak-Choudhary0 Did you figure it out? |
let @Ghat0tkach submit a pr then w'll make a feedback |
Signed-off-by: Vishrut Aggarwal <vishrut.agg@gmail.com>
Signed-off-by: Vishrut Aggarwal <vishrut.agg@gmail.com>
Signed-off-by: Vishrut Aggarwal <vishrut.agg@gmail.com>
Signed-off-by: Deepak Choudhary <114693662+Deepak-Choudhary0@users.noreply.github.com>
Signed-off-by: Deepak Choudhary <114693662+Deepak-Choudhary0@users.noreply.github.com>
Signed-off-by: Shivam Sood <shivamsood634@gmail.com>
Signed-off-by: Shivam Sood <shivamsood634@gmail.com>
Signed-off-by: Naureen <naureen.imran123@yahoo.com>
Signed-off-by: Naureen <naureen.imran123@yahoo.com>
Signed-off-by: Deepak Choudhary <114693662+Deepak-Choudhary0@users.noreply.github.com>
Signed-off-by: Deepak Choudhary <114693662+Deepak-Choudhary0@users.noreply.github.com>
Signed-off-by: Deepak Choudhary <deepakchoudharysl78@gmail.com>
adfe506
to
2e71c5c
Compare
Description
This PR fixes #
This PR solves the issue #4219
by adding a form at https://layer5.io/learn/service-mesh-books/the-enterprise-path-to-service-mesh-architectures-2nd-edition.
Still need a review before making the merge, like the data shown after signing up for book. I'm open for any improvements.
Notes for Reviewers
Signed commits