Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed jpg/png images to webp #4290

Merged
merged 4 commits into from Jun 4, 2023
Merged

changed jpg/png images to webp #4290

merged 4 commits into from Jun 4, 2023

Conversation

AkashS20
Copy link
Member

Description

This PR fixes #4281

Converted all images in jpg/png format to webp and made corresponding changes to the import statements on all pages, replacing .jpg/.png with .webp.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Akash Singh <akashsingh.mail2@gmail.com>
@github-actions github-actions bot added area/blog New posts or new blog functionality area/careers area/ci area/community area/events area/handbook area/learn Related to /learn section area/news A noteworthy article, event, happening area/projects An issue relating to Layer5 initiatives (projects) area/resources area/site-config project/meshery project/meshmap type/core-styls labels May 25, 2023
@l5io
Copy link
Contributor

l5io commented May 25, 2023

🚀 Preview for commit cce756c at: https://646ec2ee8945ce3e614e91b3--layer5.netlify.app

Signed-off-by: Akash Singh <92908347+AkashS20@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented May 25, 2023

🚀 Preview for commit 296376d at: https://646f5a8f542e770e8ca4e023--layer5.netlify.app

@ayushthe1
Copy link
Contributor

Thanks for the changes @AkashS20 . The changes look good and there is a good improvement in websites performance.

Signed-off-by: Akash Singh <92908347+AkashS20@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented May 29, 2023

🚀 Preview for commit b3243b2 at: https://647428fd5650442fafbef5a9--layer5.netlify.app

@Shivam-AfA
Copy link
Contributor

Shivam-AfA commented May 29, 2023

@AkashS20 This PR creates an impactful change on the website. Is this ready to be merged? Care should be taken that there are no missing .webp images. Let's go through this PR on the websites call today. I have added this as an agenda item. // @ayushthe1

@AkashS20
Copy link
Member Author

@Shivam-AfA Sure 👍

@Shivam-AfA
Copy link
Contributor

@AkashS20 Is this PR ready? // @ayushthe1

@ayushthe1
Copy link
Contributor

@Shivam-AfA I have gone through most of the pages and didn't found any error. I think it's good to go.

@Shivam-AfA
Copy link
Contributor

@ayushthe1 All right then! Merging this, and it would be nice if you could provide a brief about how much performance improvement this change has on the websites call.

@l5io
Copy link
Contributor

l5io commented Jun 4, 2023

🚀 Preview for commit 1657ef2 at: https://647c4aebaf2e9e0aeb6f1bf1--layer5.netlify.app

@Shivam-AfA Shivam-AfA merged commit b84dc45 into layer5io:master Jun 4, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality area/careers area/ci area/community area/events area/handbook area/learn Related to /learn section area/news A noteworthy article, event, happening area/projects An issue relating to Layer5 initiatives (projects) area/resources area/site-config project/meshery project/meshmap type/core-styls
Development

Successfully merging this pull request may close these issues.

[Performance] - Replace all .jpg/.png to .webp images
4 participants