Edit page

[8rxn]

Description

This PR fixes #4297

Notes for Reviewers

Signed commits

• Yes, I signed my commits.

[l5io]

🚀 Preview for commit e3b0495 at: https://6474de915889952dcf239c1f--layer5.netlify.app

[leecalcote]

@8rxn hint: you should only need to be concerned linking to the respective page here: https://github.com/layer5io/layer5/tree/master/src/pages. Beyond this, we won't be able to navigate contributors to the specific component. In some cases, they'll have to navigate to more deeply beyond the page source link. // @Shivam-AfA

[8rxn]

@8rxn hint: you should only need to be concerned linking to the respective page here: https://github.com/layer5io/layer5/tree/master/src/pages. Beyond this, we won't be able to navigate contributors to the specific component. In some cases, they'll have to navigate to more deeply beyond the page source link. // @Shivam-AfA

Thanks @leecalcote for the insight

Indeed that's what I am implementing.
Created a template string than resulted in the file url on github depending upon the location prop.

[8rxn]

Done with the implementation. Open to Reviews.

[8rxn]

Made a few more commits:

Deleted files accidentally pushed. Fixed the pathname, should not be failing anymore, missed footer-landscape-page for footer, added that.

Edit : Noticed it still failed, I'll be reworking on it.

[l5io]

🚀 Preview for commit d16d1d6 at: https://647911dd932d58184e48d0f4--layer5.netlify.app

[8rxn]

Implemented fixes pointed by @randychilau on slack.
Link works 🚀

[Shivam-AfA]

@8rxn Thanks for this! Let's showcase your efforts and ask for feedback on Monday's websites call before getting it live.

[8rxn]

@8rxn Thanks for this! Let's showcase your efforts and ask for feedback on Monday's websites call before getting it live.

Sure @Shivam-AfA
I do believe that there could maybe be some polish needed.
I changed a large number of files so it was kind of hard to track whether or not everything works flawlessly or not.
However I did test a few different type of pages and this seemed perfectly but I could have missed something or the other.

[Nikhil-Ladha]

Few issues needed to be taken care of:
The hover effect on the link is incorrect. The cursor changes to pointer on the Get Involved heading as well, which should not be the case. Also, restrict the width to fit-content such that the whole row (upto the column width) is not hoerable and only the text is.

Since, you have removed the Footer component from the Layout component all the collection pages like blogs, resources etc doesn't have the Footer now (eg: https://647911dd932d58184e48d0f4--layer5.netlify.app/blog/community/building-amazing-open-source-tools-one-contributor-at-a-time). That has to be fixed. You could handle these cases by pointing them to individual pages. Also, keep in mind that the content for learning-paths is stored in a separate directory named content-learn so a special case for that needs to be handled as well.
Secondly, what if we pass the location property to the Footer component directly from the Layout compoonent, does it not get the actual page location in its porps?

[8rxn]

Thanks for the insights @Nikhil-Ladha
I'll be taking care of these issues.
Regarding the Layout, the location prop is only accessible from inside the pages, hence it does not work that way. I did try that beforehand just to avoid changing a large number of files.

[8rxn]

With great help from @randychilau , I have worked on the issue in another branch with a better implementation and created a new PR for the same.
The changes requested in this PR have been implemented on that branch. Link to new PR : #4334
Requesting reviews from @Nikhil-Ladha
I'll be closing this PR.