Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[Added tooltip hover effect on the badges] #5003

Merged

Conversation

ankushbhardwaj408
Copy link
Member

Description

This PR fixes #3797
Added tooltip hover effect on the badges in individual member profile page.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

… page

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
… page

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@l5io
Copy link
Contributor

l5io commented Oct 4, 2023

🚀 Preview for commit 3f150a5 at: https://651d9b7c0c65db236791fcd6--layer5.netlify.app

Copy link
Contributor

@DarrenDsouza7273 DarrenDsouza7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ankushbhardwaj408

Could you please bring up this topic during our upcoming weekly meeting?
I've noticed that the tooltips are still off-centered, and it might be helpful to increase the distance between the tooltips and the badges slightly. This would prevent them from overlapping with some of the badges.

Thank you

@ankushbhardwaj408
Copy link
Member Author

Hi @DarrenDsouza7273 i will add this issue to the meeting agenda.

@l5io
Copy link
Contributor

l5io commented Oct 7, 2023

🚀 Preview for commit ae2027c at: https://652141144195596901240d73--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@l5io
Copy link
Contributor

l5io commented Oct 7, 2023

🚀 Preview for commit d28c227 at: https://652147a47dda7a6ff8ba7406--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@l5io
Copy link
Contributor

l5io commented Oct 7, 2023

🚀 Preview for commit 64fe283 at: https://65214dc05f88896d9c583fc8--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

Hey @ankushbhardwaj408 thanks for taking this up, could you please increase the size of text inside the tooltip to maybe 14px so that the name of the badge is visible more clearly?

@ankushbhardwaj408
Copy link
Member Author

Sure @ritiksaxena124 on it.

@l5io
Copy link
Contributor

l5io commented Oct 7, 2023

🚀 Preview for commit 3abd982 at: https://65219acf477a95215aa3700b--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@l5io
Copy link
Contributor

l5io commented Oct 7, 2023

🚀 Preview for commit fb62435 at: https://65219fac5f88891f05583fec--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Oct 9, 2023

Hey @ankushbhardwaj408 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes

@l5io
Copy link
Contributor

l5io commented Oct 9, 2023

🚀 Preview for commit 63f485e at: https://6523e27b54782b00873b5505--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@ankushbhardwaj408
Copy link
Member Author

Recording.2023-10-10.120552.mp4

@abhijeetgauravm @vishalvivekm @ritiksaxena124 @DarrenDsouza7273

@l5io
Copy link
Contributor

l5io commented Oct 10, 2023

🚀 Preview for commit b6e93fd at: https://6524f49430106b17e6ac73a2--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Recording.2023-10-10.120552.mp4
@abhijeetgauravm @vishalvivekm @ritiksaxena124 @DarrenDsouza7273

Looks good!

@l5io
Copy link
Contributor

l5io commented Oct 12, 2023

🚀 Preview for commit 8ef701a at: https://6527fca0b12eff1fe3dbbdbf--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

Merge conflicts @ankushbhardwaj408

@ankushbhardwaj408
Copy link
Member Author

@ritiksaxena124 i'll look into it

@l5io
Copy link
Contributor

l5io commented Oct 18, 2023

🚀 Preview for commit 043a652 at: https://652f6b817008be57444e8fb5--layer5.netlify.app

@ankushbhardwaj408
Copy link
Member Author

@ritiksaxena124 all issues resolved.

@ritiksaxena124
Copy link
Contributor

Great Looks good to me @ankushbhardwaj408 👏

@ritiksaxena124 ritiksaxena124 merged commit 684dddd into layer5io:master Oct 18, 2023
4 checks passed
@ankushbhardwaj408 ankushbhardwaj408 deleted the ankushbhardwaj408-#3797 branch October 18, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip on hover effect on the badges in Individual member profile page.
5 participants