Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding glow & hover effect to the clickable cards #5112

Merged
merged 4 commits into from Nov 29, 2023

Conversation

trinayreddy4
Copy link
Contributor

@trinayreddy4 trinayreddy4 commented Nov 11, 2023

Signed By TrinayReddy Malireddy Trinayreddy4@gmail.com#5044

Description
By This PR i added the glow and hover effect to the clickable cards
This PR fixes #5044

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

…ayReddy Malireddy <Trinayreddy4@gmail.com layer5io#5044

Signed-off-by: Trinay Reddy <Trinayreddy4@gmail.com>
@github-actions github-actions bot added the area/learn Related to /learn section label Nov 11, 2023
Signed-off-by: MALIREDDY TRINAY REDDY <109901688+trinayreddy4@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Nov 11, 2023

🚀 Preview for commit 16a0398 at: https://654f9e724b848b493c8f7630--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @trinayreddy4 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@Mohith234 Mohith234 changed the title Adding glow & hover effect to the clickable cards Signed-off-by: Trin… Adding glow & hover effect to the clickable cards Nov 13, 2023
Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The cards still don't get a perfect curve for the glow if you observe. Please fix this.

Also, All the cards are not of the same size. Would you fix that too? @trinayreddy4

@trinayreddy4
Copy link
Contributor Author

trinayreddy4 commented Nov 13, 2023

@Mohith234 can you please let me know size refers to the width of the cards ? Because all the cards are already of the same height. and how about making the cards with round edges as other cards in the website?

@trinayreddy4
Copy link
Contributor Author

@Mohith234 @abhijeetgauravm any insights on this??

@Mohith234
Copy link
Member

I was referring to this @trinayreddy4 , Also yes you can make it rounded to look consistent throughout the website

image

@trinayreddy4
Copy link
Contributor Author

trinayreddy4 commented Nov 20, 2023

@Mohith234 got it.....

Signed-off-by: MALIREDDY TRINAY REDDY <109901688+trinayreddy4@users.noreply.github.com>
@l5io
Copy link
Contributor

l5io commented Nov 20, 2023

🚀 Preview for commit 477e1d5 at: https://655b54625ad3630bb61908e9--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Nov 26, 2023

Hey @trinayreddy4 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leecalcote leecalcote merged commit 4a3f5a6 into layer5io:master Nov 29, 2023
4 checks passed
@trinayreddy4 trinayreddy4 deleted the glow branch November 30, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/learn Related to /learn section
Development

Successfully merging this pull request may close these issues.

[UI] Missing Hover effect on clickable cards
5 participants