Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much spaces between contribution and General contribution flow #4636 #5125

Closed
wants to merge 1 commit into from

Conversation

AbiodunVlad
Copy link
Contributor

@AbiodunVlad AbiodunVlad commented Nov 14, 2023

Much spaces between contribution and General contribution flow #4636

Description

This PR fixes #4636

Notes for Reviewers
I fixed all the excess spaces on all the pages in Handbook. All the pages had the problem and not just the listed pages.

Signed commits

  • Yes, I signed my commits.

 Duplicate 'Subscribe to Newsletter' on Blog Page #4987
@l5io
Copy link
Contributor

l5io commented Nov 14, 2023

🚀 Preview for commit a8c7fda at: https://6553d4644d4d0108a2c9dde2--layer5.netlify.app

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change isn't visible @AbiodunVlad . Please make your commit creating a new branch!

@AbiodunVlad
Copy link
Contributor Author

@abhijeetgauravm Please check now if the change is visible now.

@abhijeetgauravm
Copy link
Contributor

@abhijeetgauravm Please check now if the change is visible now.

No @AbiodunVlad it's not visible!

@AbiodunVlad
Copy link
Contributor Author

Hi @abhijeetgauravm push again and it says there is no conflict on my end. The changes I made in the code are also visible here. What could be wrong?
The changes are effected in my local server.

@ritiksaxena124
Copy link
Contributor

There are 0 files changed @AbiodunVlad. When you clone the repository in your local machine make sure to create a new branch first -> make the changes in that newly created branch and then make a PR with that new branch to avoid this kind of issue.
image

@leecalcote
Copy link
Member

Duplicated by #5125. Closing.

@leecalcote leecalcote closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Much spaces between contribution and General contribution flow
5 participants