Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recognition.js #5538

Closed
wants to merge 1 commit into from
Closed

Conversation

bunnyDasari
Copy link

@bunnyDasari bunnyDasari commented May 15, 2024

I have changed the recognitionsstyle from 0.5 rem to 1 rem as mentioned in the issue

fixes #5520
Name of the issue : Add spacing on Recognition page
Description

This PR fixes #
incresed the space between the Activity badges points

Signed commits

  • Yes, I signed my commits.

changed the recongnitionsstyle marginBottom: 0.5 to 1 rem as mentioned in the issue

Signed-off-by: Dasari Rohan <104191071+bunnyDasari@users.noreply.github.com>
@bunnyDasari
Copy link
Author

I am writing to inform you that the issue regarding style has been successfully resolved. Please feel free to reach out if you encounter any other issues.

@l5io
Copy link
Contributor

l5io commented May 15, 2024

🚀 Preview for commit cd1de86 at: https://6644470652099b54ced02116--layer5.netlify.app

@vishalvivekm
Copy link
Member

vishalvivekm commented May 18, 2024

I am writing to inform you that the issue regarding style has been successfully resolved. Please feel free to reach out if you encounter any other issues.

@bunnyDasari Thank you. Will you please link the PR with corresponding open issue ?
You can do so, by including fixes #<PR-number> in PR's description above

@bunnyDasari
Copy link
Author

@vishalvivekm fixes #5520
Name of the issue : Add spacing on Recognition page

@psankhe28
Copy link

@vishalvivekm fixes #5520 Name of the issue : Add spacing on Recognition page

If possible, edit it in the PR description itself
Here: This PR fixes #

@bunnyDasari
Copy link
Author

@psankhe28 done. I have edited in description itself

@vishalvivekm fixes #5520 Name of the issue : Add spacing on Recognition page

If possible, edit it in the PR description itself Here: This PR fixes #

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't see any space between badges: @bunnyDasari
image

add slight space between these list of badges

@sudhanshutech
Copy link
Member

@bunnyDasari are you working on the changes suggested, any help?

@bunnyDasari
Copy link
Author

@bunnyDasari are you working on the changes suggested, any help?

yeah i have changed in github itself but im unable to run project locally can please help me with this

@sudhanshutech
Copy link
Member

can you share your issue in website call today:

@bunnyDasari
Copy link
Author

@sudhanshutech im busy with my end sem exams from past 15days can i attend upcoimg meetings

@bunnyDasari bunnyDasari closed this Jul 2, 2024
@bunnyDasari bunnyDasari deleted the patch-2 branch July 2, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add spacing on Recognition page
5 participants