make integrations column visible in mobile view #5559
Conversation
|
🚀 Preview for commit e3fa1f5 at: https://665db5f9979a3ebb3cb1f169--layer5.netlify.app |
|
Thank you, @JayKay24! 😀 |
| //box-shadow: ${(props) => props.theme.boxShadowBlue477E96}; | ||
| transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1); | ||
| overflow: hidden; | ||
| position: relative; |
There was a problem hiding this comment.
remove this unnecessary lints please
There was a problem hiding this comment.
I believe this indentation is necessary to make it easier to distinguish between the CSS selector and the properties under it. Prior to my change, the selector and properties were all indented on the same level, making it hard to identify nested selectors.
| @@ -83,6 +83,7 @@ yarn.lock | |||
|
|
|||
| #IDE Files | |||
| .vscode | |||
| .idx | |||
There was a problem hiding this comment.
I'm using a new IDE called Project IDX. Comes with its own config directory, just like .vscode, which does not belong in the codebase, hence I ignored it on this .gitignore.
There was a problem hiding this comment.
ok make sense, can you raise this as a separate issue and pr and keep this pr separate . so we can move forward this quickly
|
Thank you, @sudhanshutech 👏 |
Signed-off-by: jameskinyua590 <jameskinyua590@gmail.com>
JayKay24
force-pushed
the
fix/home-integrations-column-not-visible
branch
from
e3fa1f5
to
cb5f057
Compare
|
🚀 Preview for commit cb5f057 at: https://66606bcdb58c8f1e20bc8c0e--layer5.netlify.app |
|
@JayKay24 Notice at the following screen size text and button doesn't show up?
|
|
@iArchitSharma Yes, I noticed. It's a problem also present in the production version. I think it should be a separate issue. |
|
@JayKay24 Also from width 679 to 417 both the container or columns should be aligned equally, just like they are on width 350
|
Thanks, please fix it on the same PR, also somewhere around 950 - 960 width the class |
|
@JayKay24 Thank you for your contributions. |
|
@JayKay24 Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes. |
|
@Deepak0320Singhal I'm still working on this. Will not make it to the Website's meeting. |
|
@JayKay24 if you are finding it difficult to move forward with the changes here due to your availability and other commitments, please let us know if we need to consider reassigning the item to some other contributors/ |
|
@vishalvivekm Sure. Lets assign this to someone to implement these changes. I didnt foresee how hectic my schedule would become. |
|
Hi I can add this into my work on #5581 |
|
@JayKay24 what's the progress here? |
Description
This PR fixes #5514
Notes for Reviewers
Signed commits