Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MesheryAdapterPlayComponent] - Updated UI Card Margins On Management Page #2615

Merged

Conversation

adithyaakrishna
Copy link
Member

@adithyaakrishna adithyaakrishna commented Mar 30, 2021

Signed-off-by: Adithya Krishna aadithya794@gmail.com

Description

This PR Fixes #2576 and also Fixes #2661 the background of Favicon in the title bar

Which deals with the Margins/paddings of the UI Management Page
Relevant Screenshots:
Before:
image
After:
image

Favicon:

Before:
image
Fix: The white edges aren't visible right now as I've updated the logo with .png file which has a transparent background

Notes for Reviewers

  • Yes, I signed my commits.

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@netlify
Copy link

netlify bot commented Mar 30, 2021

Deploy preview for meshery-docs ready!

Built with commit 47670ca

https://deploy-preview-2615--meshery-docs.netlify.app

Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
3 participants