-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Card margins on Management page #2576
Comments
@leecalcote I would love to work on this :) |
Excellent, @adithyaakrishna 👍 |
Is there set dimensions for each box specifically within the code ? If yes couldn't you just set the boxes to the same size in accordance with the specific page to precisely position each box with the same dimensions ? |
@TeezyOg, yes, you could, although in that case, the web app would not be responsive to different sized displays and browser widths. |
Understood ill give it some more thought.
…On Tue, Mar 23, 2021, 11:53 PM Lee Calcote ***@***.***> wrote:
@TeezyOg <https://github.com/TeezyOg>, yes, you could, although in that
case, the web app would not be responsive to different sized displays and
browser widths.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2576 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHBICIZTXAYL2DND56RSFLTFFO4VANCNFSM4ZRFYE3Q>
.
|
@adithyaakrishna are you working on this? If not, please remove your assignment. |
@leecalcote I'm working on this, I had a tough time setting up the Local Dev Environment as this is the first time I'm using make as well as Go Lang, Sorry for the delay but Once I get this up and running I will make a PR immediately 😶 |
Hey @leecalcote, so I was going through this, I found the issue The padding of the cards are set to 8px, so as there are two cards next to each other, the total padding is 16px The padding of the overall box is set to 16px, by increasing it to 24px, we can fix this across all the pages, Shall I go ahead with this? |
Thanks. Does this maintain even spacing on the top and bottom of the cards when they are in rows? |
Yes, Across all pages |
Well done 👏
…On Wed, Mar 31, 2021, 11:38 AM Lee Calcote ***@***.***> wrote:
Closed #2576 <#2576> via #2615
<#2615>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2576 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHBICNE47JZ446DJ4TJZRDTGM6XFANCNFSM4ZRFYE3Q>
.
|
Current Behavior
Left and right margins on the sides of the cards on the /management pages are unequal.
Desired Behavior
These margins should be the same on both sides of the card.
Screenshot
The text was updated successfully, but these errors were encountered: