Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kumarabd/feature/helm #2866

Closed
wants to merge 13 commits into from
Closed

Kumarabd/feature/helm #2866

wants to merge 13 commits into from

Conversation

kumarabd
Copy link
Contributor

@kumarabd kumarabd commented May 7, 2021 •
edited
Loading

Description

Signed commits

  • Yes, I signed my commits.

@kumarabd
nighthawk load testing
7a76733 
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@kumarabd
modified manifest roles
0f38e1d 
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@kumarabd kumarabd requested a review from leecalcote May 7, 2021 10:10
@netlify
Copy link

netlify bot commented May 7, 2021 •
edited
Loading

Deploy preview for meshery-docs ready!

Built with commit bcf3874

https://deploy-preview-2866--meshery-docs.netlify.app

@leecalcote
Copy link
Member

@Anita-ihuman fyi. Please note this with respect to your last update to the port number for the localhost endpoint after installing Meshery with helm.

@Anita-ihuman
Copy link
Contributor

@Anita-ihuman fyi. Please note this with respect to your last update to the port number for the localhost endpoint after installing Meshery with helm.

I don't understand, Please can you explain further?

leecalcote
leecalcote requested changes May 7, 2021
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumarabd -

go: github.com/layer5io/nighthawk-go@v0.1.6: parsing /Users/abishekk/Documents/layer5/getnighthawk/go.mod: open /Users/abishekk/Documents/layer5/getnighthawk/go.mod: no such file or directory

leecalcote
leecalcote reviewed May 7, 2021
View reviewed changes
Dockerfile Outdated
@@ -42,6 +42,14 @@ COPY --from=provider-ui /out /app/provider-ui/out
COPY --from=wrk2 /wrk2 /app/cmd/wrk2
COPY --from=wrk2 /wrk2/wrk /usr/local/bin
COPY --from=nighthawk /nighthawk-go/apinighthawk/bin /usr/local/bin
RUN curl -Lo nighthawk_service-ubuntu-amd64-v1.0.1.tar.gz https://github.com/layer5io/getnighthawk/releases/download/v1.0.1/nighthawk_service-ubuntu-amd64-v1.0.1.tar.gz \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hardcode the release.

@kumarabd
Copy link
Contributor Author

@Anita-ihuman fyi. Please note this with respect to your last update to the port number for the localhost endpoint after installing Meshery with helm.

I don't understand, Please can you explain further?

It means meshery will be accessible from localhost:9081 instead of localhost:8080

@Anita-ihuman
Copy link
Contributor

Alright then, will make the change.

@Anita-ihuman Anita-ihuman mentioned this pull request May 11, 2021
Merged
1 task
@cypress
Copy link

cypress bot commented May 11, 2021 •
edited
Loading


Test summary

6 • 0 • 0 • 0

Run details
Project Meshery
Status Passed
Commit e33181c ℹ️
Started May 11, 2021 8:39 AM
Ended May 11, 2021 8:40 AM
Duration 00:30 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kumarabd
ci fixes
661cd40 
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@kumarabd
changes service account name
bcf3874 
Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@kumarabd
Copy link
Contributor Author

@ramrodo @Aisuko Any idea why the releaser chart is failing?

@Aisuko
Copy link
Member

Aisuko commented May 11, 2021

@ramrodo @Aisuko Any idea why the releaser chart is failing?

I'm working on this, please kindly manually push the latest chart to the meshery.io

@kumarabd
Copy link
Contributor Author

@Aisuko Will you be able to link the issue that you are working on in here?

@Aisuko
Copy link
Member

Aisuko commented May 12, 2021

@Aisuko Will you be able to link the issue that you are working on in here?

Sure

@Aisuko
Copy link
Member

Aisuko commented May 12, 2021

issue #2700

leecalcote added a commit that referenced this pull request May 12, 2021
@leecalcote
Merge pull request #2894 from Anita-ihuman/master
9e1788b 
Reverse in relation to issue #2866
@kumarabd kumarabd deleted the kumarabd/feature/helm branch May 19, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Meshery] Helm chart access to be updated
4 participants
@kumarabd @leecalcote @Anita-ihuman @Aisuko