Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site] Insert comma into thousandths place for number of tests run #153

Closed
leecalcote opened this issue Nov 13, 2020 · 2 comments · Fixed by #157
Closed

[Site] Insert comma into thousandths place for number of tests run #153

leecalcote opened this issue Nov 13, 2020 · 2 comments · Fixed by #157
Assignees
@jomefavourite
Labels
first-timers-only Please contribute! All are welcome. framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers help wanted Extra attention is needed language/html Issues or pull requests that use HTML language/javascript Javascript related

Comments

@leecalcote
Copy link
Member

leecalcote commented Nov 13, 2020 •
edited
Loading

Current Behavior
Just like the https://layer5.io/meshery site has the number of performance tests run with a comma inserted into the thousandths place, so too should the perf test number on the smp-spec site have a comma.

Screen Shot 2020-11-18 at 9 22 21 AM

Screen Shot 2020-11-18 at 10 22 02 AM
@leecalcote leecalcote added first-timers-only Please contribute! All are welcome. good first issue Good for newcomers help wanted Extra attention is needed framework/jekyll Issues or pull requests that use Jekyll language/html Issues or pull requests that use HTML language/javascript Javascript related labels Nov 18, 2020
@leecalcote
Copy link
Member Author

@jomefavourite interested?

@jomefavourite
Copy link
Contributor

Yh, I am

@jomefavourite jomefavourite self-assigned this Dec 7, 2020
@jomefavourite jomefavourite mentioned this issue Dec 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jomefavourite jomefavourite

Labels
first-timers-only Please contribute! All are welcome. framework/jekyll Issues or pull requests that use Jekyll good first issue Good for newcomers help wanted Extra attention is needed language/html Issues or pull requests that use HTML language/javascript Javascript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added a function for comma insertion
2 participants
@leecalcote @jomefavourite