Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github workflow for deployment preview #183

Closed
coder12git opened this issue Oct 30, 2023 · 4 comments · Fixed by #225
Closed

Add Github workflow for deployment preview #183

coder12git opened this issue Oct 30, 2023 · 4 comments · Fixed by #225
Assignees
@coder12git
Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed kind/feature New major feature or request

Comments

@coder12git
Copy link
Member

coder12git commented Oct 30, 2023 •
edited

Current Behavior

Currently, we don't have any GitHub workflow defined for deployment preview of Sistent site.
Check this PR -> #182

Desired Behavior

-> Add GitHub workflow for deployment preview.

Implementation

Acceptance Tests

Mockups

Contributor Guide
@coder12git coder12git added kind/enhancement Improvement in current feature kind/feature New major feature or request and removed kind/enhancement Improvement in current feature labels Oct 30, 2023
@coder12git
Copy link
Member Author

// @leecalcote

@leecalcote leecalcote added area/ci Continuous integration | Build and release help wanted Extra attention is needed labels Oct 30, 2023
@sudhanshutech
Copy link
Member

I think @coder12git we need to add the workflow inside your branch or otherwise we will having conflicts

@coder12git
Copy link
Member Author

I think @coder12git we need to add the workflow inside your branch or otherwise we will having conflicts

Okay, but is it possible to make an another branch in sistent dedicated for site? In this way we can merge my PR into that branch and then can do changes there.

@leecalcote
Copy link
Member

No need for a dedicated branch. master is to be used for the site just like all the other sites here.

@coder12git coder12git self-assigned this Nov 3, 2023
@coder12git coder12git mentioned this issue Nov 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coder12git coder12git

Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed kind/feature New major feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub workflows for deployment preview coder12git/sistent
5 participants
@leecalcote @aabidsofi19 @sudhanshutech @coder12git @nebula-aac