Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sistent site draft #182

Merged
merged 14 commits into from Nov 5, 2023
Merged

Sistent site draft #182

merged 14 commits into from Nov 5, 2023

Conversation

coder12git
Copy link
Member

Notes for Reviewers

"This PR represents the draft of the Sistent website. Please note that all the website's code is present inside the site folder.
Signed commits

  • Yes, I signed my commits.

@coder12git
feat(core): init
be3195b 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): added basic components-footer,navbar,sidebar
7d2e0e5 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): add and modify basic components
ec17e89 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): added basic folder structure for pages
de60e64 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): add section for color and typography
d8e8519 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
Update README.md
73f2dee 
Signed-off-by: Suruchi Kumari <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): make file
770d727 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@github-actions github-actions bot added area/docs Improvements or additions to documentation area/site labels Oct 30, 2023
@coder12git coder12git mentioned this pull request Oct 30, 2023
Closed
@coder12git
Copy link
Member Author

// @leecalcote

leecalcote
leecalcote reviewed Oct 30, 2023
View reviewed changes
site/Makefile Outdated Show resolved Hide resolved
leecalcote
leecalcote reviewed Oct 30, 2023
View reviewed changes
site/gatsby-config.js Outdated Show resolved Hide resolved
site/package.json Outdated Show resolved Hide resolved
site/src/assets/images/Chevron-light.png Outdated Show resolved Hide resolved
site/src/components/Footer/index.js Outdated Show resolved Hide resolved
@nebula-aac
Copy link
Contributor

While I understand that Yarn has its perks, and we are all learning, is it intentional to have site outside of the packages or apps?

@nebula-aac
Copy link
Contributor

While I understand that Yarn has its perks, and we are all learning, is it intentional to have site outside of the packages or apps?

I only ask because we have a way to yarn ignore site in its building process.

@leecalcote
Copy link
Member

There's some great work in here, @coder12git. 🙂

@leecalcote
Copy link
Member

While I understand that Yarn has its perks, and we are all learning, is it intentional to have site outside of the packages or apps?

Not to my knowledge, no. One Makefile to rule all components of the system sounds nice to me.

@leecalcote leecalcote closed this Oct 30, 2023
@leecalcote leecalcote reopened this Oct 30, 2023
@leecalcote
Copy link
Member

leecalcote commented Oct 30, 2023 •
edited

Oh, my word. What is going on with my mouse today?

@coder12git
Copy link
Member Author

coder12git commented Oct 30, 2023 •
edited

While I understand that Yarn has its perks, and we are all learning, is it intentional to have site outside of the packages or apps?

I only ask because we have a way to yarn ignore site in its building process.

@nebula-aac i will move this site folder inside apps with sistent-website as a folder name

@sudhanshutech sudhanshutech added the pr/draft WIP/Draft pull request label Oct 31, 2023
@sudhanshutech
Copy link
Member

@coder12git i added draft label, you can remove when done

@coder12git @leecalcote
Update site/Makefile
c9a6e65 
Co-authored-by: Lee Calcote <leecalcote@gmail.com>
Signed-off-by: Suruchi Kumari <suruchikumarimfp4@gmail.com>
coder12git and others added 3 commits November 1, 2023 08:56
@coder12git @leecalcote
Update site/gatsby-config.js
f5f78df 
Co-authored-by: Lee Calcote <leecalcote@gmail.com>
Signed-off-by: Suruchi Kumari <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): modified code as per review
200a29d 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): added all components
971a9bc 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git coder12git removed the pr/draft WIP/Draft pull request label Nov 3, 2023
leecalcote
leecalcote reviewed Nov 3, 2023
View reviewed changes
site/src/assets/images/Weather.svg Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind reusing from layer5.io?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do

Copy link
Member Author

@coder12git coder12git Nov 3, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will do

leecalcote
leecalcote reviewed Nov 3, 2023
View reviewed changes
site/src/components/Footer/index.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the same footer is reused from layer5.io

@coder12git
feat(core): added qanleas soft font and add link in 404
2007820 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): add scripts for deploy
9606021 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
@coder12git
feat(core): added dark mode
230bdd0 
Signed-off-by: coder12git <suruchikumarimfp4@gmail.com>
leecalcote
leecalcote approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site folder can be moved if you'd like, @nebula-aac. I don't have an opinion here.

@leecalcote leecalcote merged commit b20a16d into layer5io:master Nov 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhanshutech sudhanshutech sudhanshutech left review comments

@leecalcote leecalcote leecalcote approved these changes

@Rexford74 Rexford74 Awaiting requested review from Rexford74

@nebula-aac nebula-aac Awaiting requested review from nebula-aac

Assignees
No one assigned
Labels
area/docs Improvements or additions to documentation area/site
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coder12git @nebula-aac @leecalcote @sudhanshutech