[custom] Fix and Refactor react-error boundary #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
sudhanshutech
added
pr/on hold
sudhanshutech
changed the title
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
sudhanshutech
changed the title
|
@nebula-aac should we also need to move this to root |
|
@sudhanshutech there is new CSS for the MUIcheckbox's in Cloud that needs to be migrated to Sistent... |
|
@sudhanshutech can you update your PR with the latest upstream, I'll test this afterwards |
sudhanshutech
changed the title
aabidsofi19
approved these changes
Nov 28, 2023
|
@sudhanshutech conflicts, can you update this error boundary component with support button you can copy component that we have in MeshMap |
|
ok, are you referring for rjsf component? @Yashsharma1911 |
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
…sistent into fix/error-boundar
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Yashsharma1911
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #223
Signed commits