Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svg): create icons for TypingFilter component #435

Merged
merged 1 commit into from Dec 15, 2023
Merged

feat(svg): create icons for TypingFilter component #435

merged 1 commit into from Dec 15, 2023

Conversation

nebula-aac
Copy link
Contributor

fix #400

fix #341

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@nebula-aac
feat(svg): create icons for TypingFilter component
8217b49 
fix #400

fix #341

Signed-off-by: Antonette Caldwell <acald.nebula@gmail.com>
aabidsofi19
aabidsofi19 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@aabidsofi19 aabidsofi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You @nebula-aac

ritiksaxena124
ritiksaxena124 reviewed Dec 14, 2023
View reviewed changes
packages/svg/src/icons/ContentFilter/index.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the cone for the content filter other than this everything is good
Frame (2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cone? I'm not following.

I copied from Meshery Cloud UI.

@nebula-aac nebula-aac merged commit 444aa8b into master Dec 15, 2023
11 checks passed
@nebula-aac nebula-aac deleted the icons-for-typing-filter branch December 15, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritiksaxena124 ritiksaxena124 ritiksaxena124 left review comments

@aabidsofi19 aabidsofi19 aabidsofi19 approved these changes

Assignees
No one assigned
Labels
component/icons v0.15.0-planning
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[svg]: Create ReadIcon and InfoIcon, AlertIcon [svg]: Create CrossCircleIcon and ContentFilterIcon
3 participants
@nebula-aac @ritiksaxena124 @aabidsofi19