Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme for tables #629

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented May 28, 2024

Notes for Reviewers

This PR adds theme for data tables

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
@sudhanshutech
Copy link
Member Author

Note

i need to test this with meshery also then we can merge this

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
…stent into datatable/theme

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
Copy link
Contributor

@dragon-slayer875 dragon-slayer875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked in meshery and cloud. Works as expected without build error.

@leecalcote leecalcote merged commit 60d5bfc into layer5io:master Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants