Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboard build fix #206

Closed
wants to merge 5 commits into from
Closed

Conversation

Kingscliq
Copy link
Contributor

@Kingscliq Kingscliq commented Dec 4, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@horizenight
Copy link

Hello @Kingscliq
Kindly Read through the contribution guidelines again.

  1. No mention of which issue is targeted with this pr.

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.
  1. DCO check failed means not all commits were signed consider rebasing your commits and properly signing it.

@Kingscliq
Copy link
Contributor Author

Hello @Kingscliq Kindly Read through the contribution guidelines again.

  1. No mention of which issue is targeted with this pr.

Description
This PR fixes #
Notes for Reviewers
Signed commits

  • Yes, I signed my commits.
  1. DCO check failed means not all commits were signed consider rebasing your commits and properly signing it.

Hi @horizenight, it was supposed to be a new feature not like a fix, how can I capture that for the context you were speaking from?

@horizenight
Copy link

horizenight commented Dec 22, 2023

Let's tackle one problem at a time :

  1. Your Pull Request fails to mention what feature or fix, it is supposed to solve Issue [Badges] Discussion Forum Leaderboard #193. This is mentioned in contribution guidelines that PullRequest should mention the issue it was solving.

  2. This check is failing as you are not correctly signing your commits,
    so to solve that you would have to rebasing your commits and properly sign it.

image
  1. In Notes for Reviewers: Can you write in brief what have you done to solve the issue

Alternatively, use these resources:
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

📚 See contributing instructions.
🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack.
Join the Layer5 Community by submitting your community member form.

@iArchitSharma
Copy link
Contributor

iArchitSharma commented Mar 1, 2024

@Kingscliq we have two PR's on this, can we close this one?
If this PR does the same - #225

@leecalcote
Copy link
Contributor

@Kingscliq ?

@Kingscliq Kingscliq closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants