Unquoted url #13
Merged
Unquoted url #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additional parameter breaks the current implementation. A real life youtube link for this scenario is for example: https://www.youtube.com/watch?NR=1&feature=endscreen&v=lhFSc0dWsto
This solves the problem for urls with longer query strings like https://www.youtube.com/watch?NR=1&feature=endscreen&v=lhFSc0dWsto
|
Beat me to the fix. :) |
sapslaj
added a commit
that referenced
this pull request
Aug 31, 2015
Quote url in command line runner.
|
Had some free time on my hand just now, before breakfast :) Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some urls cannot be handled by youtube-dl.rb since the url as command line parameter is not wrapped in quotes.
One real world example would be:
https://www.youtube.com/watch?NR=1&feature=endscreen&v=lhFSc0dWsto
I adapted one test url for this case and fixed the implementation.