fix(EventTarget): fix subscription to events #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2018 14:46
…into chore/fix-subscription
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
- Coverage 98.72% 95.68% -3.04%
==========================================
Files 13 7 -6
Lines 469 116 -353
Branches 26 27 +1
==========================================
- Hits 463 111 -352
+ Misses 1 0 -1
Partials 5 5
Continue to review full report at Codecov.
|
layershifter
commented
Oct 2, 2018
| "plugins": [ "istanbul" ] | ||
| "plugins": [ | ||
| ["istanbul", { "exclude": ["src/**/*.spec.{ts,tsx}"] }] | ||
| ] |
There was a problem hiding this comment.
Remove useless coverage from tests
layershifter
commented
Oct 2, 2018
| @@ -70,6 +71,7 @@ | |||
| "release:major": "yarn prerelease && release-it major", | |||
| "release:minor": "yarn prerelease && release-it minor", | |||
| "release:patch": "yarn prerelease && release-it patch", | |||
| "serve": "serve lib", | |||
There was a problem hiding this comment.
This allows to serve the UMD build
layershifter
commented
Oct 2, 2018
|
|
||
| this.handlers.set(eventType, handler) | ||
| this.target.addEventListener(eventType, handler) | ||
| this.target.addEventListener(eventType, handler, true) |
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener
useCapture=true the one of important changes there
Manual checks
|
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Semantic-Org/Semantic-UI-React#3006
Details: Semantic-Org/Semantic-UI-React#3124 (comment)