Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose constants for 3rd parties #52

Open
CodeSandwich opened this issue Apr 5, 2024 · 0 comments
Open

Expose constants for 3rd parties #52

CodeSandwich opened this issue Apr 5, 2024 · 0 comments

Comments

@CodeSandwich
Copy link

CodeSandwich commented Apr 5, 2024

Some important constants used in the LZ public API aren't exposed by LZ Solidity files. For example CONFIG_TYPE_ULN and NIL_DVN_COUNT are internal despite being crucial when calling IMessageLibManager.setConfig from a smart contract.

LayerZero-v2/messagelib/test/util/Constant.sol is a great resource, maybe it could be moved out of the scary test directory? It could be used in the contracts as the source of constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant