Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Swift Package experience #232

Merged
merged 7 commits into from
Jan 6, 2024
Merged

Enhance Swift Package experience #232

merged 7 commits into from
Jan 6, 2024

Conversation

OhKanghoon
Copy link
Contributor

@OhKanghoon OhKanghoon commented Oct 3, 2023 •
edited

Background

  • Change the Swift Package Manager to be available without FLEXLAYOUT_SWIFT_PACKAGE flag

Contents

  • add public header path
  • remove FLEXLAYOUT_SWIFT_PACKAGE
  • remove library for internal (FlexLayoutYoga, FlexLayoutYogaKit)
  • move the unit test to the swift package with XCTest

@OhKanghoon OhKanghoon changed the title Enhance swift package Enhance Swift Package Environment Oct 3, 2023
@OhKanghoon OhKanghoon changed the title Enhance Swift Package Environment Enhance Swift Package experience Oct 3, 2023
@luoxiu
Copy link

luoxiu commented Dec 8, 2023

@lucdion could you please review this?

lucdion
lucdion approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@lucdion lucdion left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @OhKanghoon for the long delay, I missed the PR.
Really nice clean up, really good job 👏

Last thing, could you update the README here https://github.com/layoutBox/FlexLayout#in-an-xcode-target

Thanks

@OhKanghoon
Copy link
Contributor Author

OhKanghoon commented Dec 15, 2023 •
edited

Sorry @OhKanghoon for the long delay, I missed the PR. Really nice clean up, really good job 👏

Last thing, could you update the README here https://github.com/layoutBox/FlexLayout#in-an-xcode-target

Thanks

Thank you for reviewing this PR.

I remove FLEXLAYOUT_SWIFT_PACKAGE content in README.md 8c5177d

@lucdion
Copy link
Member

lucdion commented Dec 15, 2023

@OhKanghoon , you must update the PR's branch. Thanks

@OhKanghoon
Copy link
Contributor Author

OhKanghoon commented Dec 15, 2023 •
edited

@OhKanghoon , you must update the PR's branch. Thanks

@lucdion Checked it! 👍

@lucdion lucdion merged commit 7208da8 into layoutBox:master Jan 6, 2024
1 check passed
@lucdion
Copy link
Member

lucdion commented Jan 6, 2024

I have merged an published a new release. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucdion lucdion lucdion approved these changes

@luoxiu luoxiu luoxiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OhKanghoon @luoxiu @lucdion