Add feature for Gap #241
Merged
Add feature for Gap #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucdion
reviewed
Jan 9, 2024
| @@ -159,4 +163,101 @@ final class WidthSizeContentTests: XCTestCase { | |||
| rootFlexContainer.flex.layout() | |||
| XCTAssertEqual(aView.frame, CGRect(x: 0.0, y: 0.0, width: 400.0, height: 200.0)) | |||
| } | |||
|
|
|||
| func test_set_gap_in_row_direction() { | |||
There was a problem hiding this comment.
Thanks for adding all those unit tests!
|
OK I updated README and Comments of gap! |
lucdion
approved these changes
Jan 11, 2024
|
@Skyline-23 , could you update your branch, I have fixed the CI. Then after, I will be able to merge your PR. thanks |
|
I updated it. Thank you! |
OhKanghoon
reviewed
Jan 11, 2024
OhKanghoon
reviewed
Jan 11, 2024
Co-authored-by: Ray (Kanghoon Oh) <ggaa96@naver.com>
|
Your fix has been released. Thanks for this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add features
columnGap(_ value: CGFloat) -> FlexrowGap(_ value: CGFloat) -> Flexgap(_ value: CGFloat) -> Flexbackground
After Yoga layout updated to 2.0.0 the gap func added. and as needed by this issue and my company's product, me and my partner @TaekH made feature to use. 🙇♂️
Addition
the direction (row, column) is shows swapped. I think maybe it is issue from yoga layout