V2 add time manipulation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 13, 2020 22:12
…ew java.time api, e.g., plusDays, etc
…ew java.time api, e.g., plusDays, etc
|
Wow! Thanks! I will go through it within a couple of days @jeffyjin |
lazee
reviewed
Apr 14, 2020
| * Freemarker ObjectWrapper that extends the Java8ObjectWrapper with support for time manipulations in all temporal classes in the new java.time api. | ||
| * Such time manipulation operations include plusSeconds, plusMinutes, etc. | ||
| */ | ||
| public class EnhancedJava8ObjectWrapper extends Java8ObjectWrapper { |
There was a problem hiding this comment.
Why this Enhanced wrapper ? Couldn't we just add it to the Java8ObjetWrapper ?
There was a problem hiding this comment.
Of course. I didn't want to be too intrusive. I actually more prefer to merge the changes into Java8ObjetWrapper. Will modify PR soon
There was a problem hiding this comment.
Thanks! I will look into this and merge it soon. I think v2 should be released within a week or so.
|
2.0.0 release @jeffyjin. Available tomorrow from central repo. Again, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lazee, as per your request, I re-applied the PR to V2 and added test cases and updated README.md. Please let me know your thoughts. Thanks