Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error if Collection View doesn't have empty view #94

Closed
abdullin opened this issue Sep 17, 2014 · 1 comment
Closed

Throw an error if Collection View doesn't have empty view #94

abdullin opened this issue Sep 17, 2014 · 1 comment

Comments

@abdullin
Copy link

Currently, if the a view collection does not have an empty view assigned AND collection is empty, lazo will just silently timeout on server-side rendering, throwing Uncaught error: Invalid nested use of protect.run() from HAPI internals.

AFAIK, that is caused by the fact that controller._getEmptyViewInstance does not find anything and callbacks don't get fired.

May be lazo could guard against such common mistake by newbies by throwing an error or at least printing a warning?
@jstrimpel
Copy link
Contributor

A fix for this was just released, https://github.com/walmartlabs/lazojs/releases/tag/v0.2.0. Please reopen if you continue experiencing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jstrimpel @abdullin