New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code runs in SQL error for height = 0 in QueryBuilder::columnPatch(...) #587

Open

gregor-gabriel opened this issue Jul 21, 2023 · 0 comments

gregor-gabriel commented Jul 21, 2023

https://github.com/lazychaser/laravel-nestedset/blob/2d5c99fe1bfbaa4004f8d6fb24475f7ff88bb526/src/QueryBuilder.php#L643C11-L643C14

In line 638 there is function columnPatch(...)

    protected function columnPatch($col, array $params)
    {
        extract($params);

        /** @var int $height */
        if ($height > 0) $height = '+'.$height;
        ...

checks $height > 0 but it should check $height >= 0

otherwise it generates an invalid SQL snippet if $cut is set.

The text was updated successfully, but these errors were encountered:

evgenyneverov mentioned this issue

Bugfix in QueryBuilder::columnPatch #595

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment