Implement hash methods in C++ #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, expose them into Java as hashCode().
Merged
eltoder
added a commit
to eltoder/QuantLib-SWIG
that referenced
this pull request
Jan 29, 2024
* Fix comparing Money in Python: `__eq__` and `__ne__` were missing. * Expose `__cmp__` as compareTo() in Java. This is the correct name for this method. "compare" is for Comparators[1][2]. Note that this is only a change for Money. Period and Date did not have `__cmp__` exposed in Java until lballabio#610. * Remove `__cmp__` and `__nonzero__` methods from Python. These were Python 2 magic methods that are not used in Python 3[3]. [1] https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T- [2] https://docs.oracle.com/javase/8/docs/api/java/util/Comparator.html#compare-T-T- [3] https://docs.python.org/3/reference/datamodel.html
eltoder
added a commit
to eltoder/QuantLib-SWIG
that referenced
this pull request
Jan 30, 2024
* Fix comparing Money in Python: `__eq__` and `__ne__` were missing. * Expose `__cmp__` as compareTo() in Java. This is the correct name for this method. "compare" is for Comparators[1][2]. Note that this is only a change for Money. Period and Date did not have `__cmp__` exposed in Java until lballabio#610. Also, implement Comparable<T> interface. * Remove `__cmp__` and `__nonzero__` methods from Python. These were Python 2 magic methods that are not used in Python 3[3]. [1] https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T- [2] https://docs.oracle.com/javase/8/docs/api/java/util/Comparator.html#compare-T-T- [3] https://docs.python.org/3/reference/datamodel.html
eltoder
added a commit
to eltoder/QuantLib-SWIG
that referenced
this pull request
Jan 30, 2024
* Fix comparing Money in Python: `__eq__` and `__ne__` were missing. * Expose `__cmp__` as compareTo() in Java. This is the correct name for this method. "compare" is for Comparators[1][2]. Note that this is only a change for Money. Period and Date did not have `__cmp__` exposed in Java until lballabio#610. Also, implement Comparable<T> interface. * Remove `__cmp__` and `__nonzero__` methods from Python. These were Python 2 magic methods that are not used in Python 3[3]. [1] https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T- [2] https://docs.oracle.com/javase/8/docs/api/java/util/Comparator.html#compare-T-T- [3] https://docs.python.org/3/reference/datamodel.html
eltoder
added a commit
to eltoder/QuantLib-SWIG
that referenced
this pull request
Jan 30, 2024
* Fix comparing Money in Python: `__eq__` and `__ne__` were missing. * Expose `__cmp__` as compareTo() in Java. This is the correct name for this method. "compare" is for Comparators[1][2]. Note that this is only a change for Money. Period and Date did not have `__cmp__` exposed in Java until lballabio#610. Also, implement Comparable<T> interface. * Remove `__cmp__` and `__nonzero__` methods from Python. These were Python 2 magic methods that are not used in Python 3[3]. [1] https://docs.oracle.com/javase/8/docs/api/java/lang/Comparable.html#compareTo-T- [2] https://docs.oracle.com/javase/8/docs/api/java/util/Comparator.html#compare-T-T- [3] https://docs.python.org/3/reference/datamodel.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, expose them into Java as hashCode().