Use %extend for properties of Settings #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SWIG native way to add properties to Settings[1]. This works with all target languages using the most natural feature available (e.g. properties in Python and C# and get/set methods in Java). For now only enable this for Python. Other languages are easy as well, except for backward compatibility concerns. Also, deprecate get/set methods in Python. [1] https://www.swig.org/Doc4.2/SWIG.html#SWIG_adding_member_functions near the end of the section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SWIG native way to add properties to Settings[1]. This works with all target languages using the most natural feature available (e.g. properties in Python and C# and get/set methods in Java).
For now only enable this for Python. Other languages are easy as well, except for backward compatibility concerns.
Also, deprecate get/set methods in Python.
[1] https://www.swig.org/Doc4.2/SWIG.html#SWIG_adding_member_functions near the end of the section.