Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes to 30/360 day count convention #1100

Merged
merged 3 commits into from May 28, 2021
Merged

A few changes to 30/360 day count convention #1100

merged 3 commits into from May 28, 2021

Conversation

lballabio
Copy link
Owner

  • Added ISMA convention (similar to NASD but doesn't adjust to next month);
  • BondBasis is now, correctly, an alias to ISMA;
  • German is now also called ISDA;
  • reordered code to model logic more closely;
  • deprecated default constructor; a convention should always be passed explicitly.

@lballabio lballabio added this to the 1.23 release milestone May 27, 2021
@coveralls
Copy link

coveralls commented May 27, 2021

Coverage Status

Coverage increased (+0.006%) to 71.065% when pulling 67b6633 on thirty360 into 717025c on master.

@lballabio lballabio merged commit 542c208 into master May 28, 2021
@lballabio lballabio deleted the thirty360 branch May 28, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants