Fix Calibration Errors in G2 #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been some issues the lower bound becomes minus infinity as y=-100 is a very low value. Instead of having the interval, where we solve for y-bar, hard-coded, it is now set to plus/minus 10 standard deviations.
mmencke
added a commit
to mmencke/QuantLib
that referenced
this pull request
Jun 29, 2021
I forgot to credit myself in pull request lballabio#1122 and lballabio#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1087.
There has been some issues the lower bound becomes minus infinity as y=-100 is a very low value.
Instead of having the interval, where we solve for y-bar, hard-coded, it is now set to plus/minus 10 standard deviations.