Move credit spread and dividends to Binomial Convertible Engine #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Oct 30, 2021
Comment on lines
181
to
183
| Handle<Quote> creditSpread; //Not being used for calculations in binomailconvertibleengine | ||
| DividendSchedule dividends; //Not being used for calculations in binomailconvertibleengine | ||
| std::vector<Date> dividendDates; |
There was a problem hiding this comment.
I would remove these from here as well. They can be passed from the engine to DiscretizedConvertible's constructor.
|
Thanks! I'll try to do some more cleanup and move it out of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1217