Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::reverse_iterator with std::reverse_iterator #1676

Merged
merged 1 commit into from
May 22, 2023

Conversation

sweemer
Copy link
Contributor

@sweemer sweemer commented May 19, 2023

@lballabio Do you remember why this code uses boost::reverse_iterator even though std::reverse_iterator has been around since before C++11? As far as I can tell, they both have the same requirements (see here and here) so I don't think there should have been any benefit of using boost over std originally.

This change affects the public interface, but I think it's fine, because users should be using either auto or the typedef type, not the underlying type.

@coveralls
Copy link

Coverage Status

Coverage: 71.964% (+0.0004%) from 71.963% when pulling b2fa56a on sweemer:reverse_iterator into 5182331 on lballabio:master.

@lballabio lballabio added this to the Release 1.31 milestone May 22, 2023
@lballabio
Copy link
Owner

I don't remember, but if I had to take I guess I'd say that back in the mesozoic period some of the compilers were slow in implementing everything that was defined in the C++ standard library. Kids have it easy these days 😄

@lballabio lballabio merged commit ebbb375 into lballabio:master May 22, 2023
44 checks passed
@sweemer sweemer deleted the reverse_iterator branch May 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants