Replace boost::reverse_iterator with std::reverse_iterator #1676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lballabio Do you remember why this code uses
boost::reverse_iterator
even thoughstd::reverse_iterator
has been around since before C++11? As far as I can tell, they both have the same requirements (see here and here) so I don't think there should have been any benefit of using boost over std originally.This change affects the public interface, but I think it's fine, because users should be using either
auto
or thetypedef
type, not the underlying type.