Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - São Paulo city holiday just for years before 2022 #1897

Merged

Conversation

marcobfv
Copy link
Contributor

Fix - São Paulo city holiday just for years before 2022 for Brazilian exchange holidays.

Official statement:
B3 News

Current rule for holidays:
B3 trading calendar

Copy link

boring-cyborg bot commented Jan 26, 2024

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 26, 2024

Coverage Status

coverage: 72.361% (+0.03%) from 72.328%
when pulling ff16f2f on marcobfv:fix-holiday-exchange-brazil-saopaulocity
into 605ce81 on lballabio:master.

@marcobfv
Copy link
Contributor Author

marcobfv commented Jan 30, 2024

@lballabio Hi there! Just checking if my PR is right, can you tell me if it's been analyzed or there something else i should do?

@lballabio
Copy link
Owner

That's ok, thanks, just a bit of backlog on my side. We should just update the docs in the hpp file but I can do it.

@lballabio lballabio added this to the Release 1.34 milestone Jan 31, 2024
@lballabio lballabio merged commit 772d19a into lballabio:master Jan 31, 2024
48 checks passed
Copy link

boring-cyborg bot commented Jan 31, 2024

Congratulations on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants