Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused and broken bond helper inspector #1901

Merged
merged 4 commits into from Feb 1, 2024

Conversation

yyuuhhjjnnmm
Copy link
Contributor

No description provided.

@yyuuhhjjnnmm
Copy link
Contributor Author

For #333

@coveralls
Copy link

coveralls commented Jan 31, 2024

Coverage Status

coverage: 72.422% (+0.001%) from 72.421%
when pulling fca2359 on yyuuhhjjnnmm:master
into daba5ab on lballabio:master.

@lballabio
Copy link
Owner

lballabio commented Feb 1, 2024

Thanks—I modified your PR so it deprecates the methods instead of removing them, to avoid breaking other people's code that might use them. This way they will get a warning. We'll remove them in a future version.

@lballabio
Copy link
Owner

Sorry about the failed builds—it turns out that gcc emits more deprecation warnings than clang.

@lballabio lballabio changed the title [QL-333] deprecate unused and broken bond helper inspector Deprecate unused and broken bond helper inspector Feb 1, 2024
@lballabio lballabio merged commit 6d66cce into lballabio:master Feb 1, 2024
48 checks passed
@lballabio lballabio added this to the Release 1.34 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bond helper constructors lose specific type information on underlying bond
3 participants