Add Futures::Type Custom #1915
Merged
Add Futures::Type Custom #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Feb 21, 2024
| default: | ||
| QL_FAIL("unknown futures type (" << Integer(type) << ')'); | ||
| QL_FAIL("unknown futures type (" << type << ')'); |
There was a problem hiding this comment.
Without the cast to Integer, this is going to trigger the QL_FAIL in operator<< — in this case the message will be the same, but in others the message there will override the original one.
There was a problem hiding this comment.
Removed QL_FAIL from operator<<, so now it is safe to use.
This allows passing custom future dates. Closes lballabio#1855
eltoder
force-pushed
the
feature/custom-future-type
branch
from
d094c60
to
1917baf
Compare
ninetiger
pushed a commit
to ninetiger/QLNet
that referenced
this pull request
Apr 15, 2024
This is trnasfered from the C++ code: lballabio/QuantLib#1915 This allows passing custom future dates. Closes #1855: lballabio/QuantLib#1855
amaggiulli
pushed a commit
to amaggiulli/QLNet
that referenced
this pull request
Apr 16, 2024
* Added Futures Type - Custom; This is trnasfered from the C++ code: lballabio/QuantLib#1915 This allows passing custom future dates. Closes #1855: lballabio/QuantLib#1855 * Update the default case message only --------- Co-authored-by: Xiao Gong <xiao.gong@nzfunds.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing custom future dates. Closes #1855