Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HK public holiday(2015-09-03) #881

Closed
wants to merge 1 commit into from

Conversation

CarrieMY
Copy link
Contributor

@CarrieMY CarrieMY commented Aug 8, 2020

Closes #880

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 8, 2020

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


CarrieMY seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lballabio lballabio added this to the 1.20 release milestone Aug 8, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 71.02% when pulling c825b67 on CarrieMY:bugfix into 32f864a on lballabio:master.

@lballabio
Copy link
Owner

Thank you! Would you mind clicking on the link in the CLAssistant comment above to sign your contribution?

@CarrieMY
Copy link
Contributor Author

Hi I just found I made a mistake in the commit that my email address is incorrectly put thus CLA cannot be signed. So sorry for this mistake. Let me close this PR and correct it.

@CarrieMY CarrieMY closed this Aug 10, 2020
@lballabio lballabio removed this from the 1.20 release milestone Aug 10, 2020
@lballabio
Copy link
Owner

No problem, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing a Non-weekend Hong Kong Holiday(2015)
4 participants