Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New charge rate service #1050

Merged
merged 16 commits into from
Jan 27, 2024
Merged

New charge rate service #1050

merged 16 commits into from
Jan 27, 2024

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Jan 19, 2024

No description provided.

@drc38 drc38 marked this pull request as draft January 19, 2024 04:53
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5915dc3) 0.00% compared to head (97dc3cf) 90.57%.

Files Patch % Lines
custom_components/ocpp/api.py 93.10% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1050       +/-   ##
=========================================
+ Coverage      0   90.57%   +90.57%     
=========================================
  Files         0       10       +10     
  Lines         0     1380     +1380     
  Branches      0      228      +228     
=========================================
+ Hits          0     1250     +1250     
- Misses        0       74       +74     
- Partials      0       56       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drc38 drc38 marked this pull request as ready for review January 23, 2024 07:12
@mazzy89
Copy link
Contributor

mazzy89 commented Jan 25, 2024

Any possibilities to have this merged in the upcoming days?

@lbbrhzn lbbrhzn merged commit 62353b6 into main Jan 27, 2024
8 checks passed
@lbbrhzn lbbrhzn deleted the new_service branch January 27, 2024 17:40
@mazzy89
Copy link
Contributor

mazzy89 commented Feb 8, 2024

Hey, team. Could you let me know if you will release the component anytime soon? A few notable features and fixes would be nice to have as this one and avoid to pull the repo manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants