Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodetect supported measurands #968

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

lbbrhzn
Copy link
Owner

@lbbrhzn lbbrhzn commented Nov 6, 2023

add autodetection of supported measurands.

If this works well, we can remove configuration of the measurands from the config flow.

@lbbrhzn lbbrhzn linked an issue Nov 6, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #968 (ca13b2c) into main (a61e940) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   90.34%   90.51%   +0.16%     
==========================================
  Files          10       10              
  Lines        1346     1349       +3     
  Branches      223      221       -2     
==========================================
+ Hits         1216     1221       +5     
+ Misses         75       74       -1     
+ Partials       55       54       -1     
Files Coverage Δ
custom_components/ocpp/api.py 87.43% <100.00%> (+0.18%) ⬆️
custom_components/ocpp/config_flow.py 100.00% <100.00%> (+8.00%) ⬆️
custom_components/ocpp/const.py 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lbbrhzn lbbrhzn requested a review from drc38 November 6, 2023 21:58
Copy link
Collaborator

@drc38 drc38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test with my charger for another week, but the changes lgtm

@lbbrhzn lbbrhzn merged commit 64dab6e into main Nov 10, 2023
8 checks passed
@lbbrhzn lbbrhzn deleted the 952-automatically-detect-supported-measurands branch November 10, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically detect supported measurands
2 participants