Added support for Solr5 query highlighting. Fixes #130 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luketaverne
added a commit
that referenced
this pull request
Aug 27, 2015
Added support for Solr5 query highlighting. Fixes #130
|
Hi luketaverne, could we use this node module in Angular ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written based on the StandardHighlighter specification on the Solr wiki here.
There are also FastVectorHighlighter and PostingsHighlighter which I did not include. They use many of the same parameters as the StandardHighlighter. However, there are certain parameters that are only valid for certain highlighters. I'm thinking I will just add these two highlighters, and their special parameters, as options to this hl function. This project seems to leave it up to the user to use the proper Solr query parameters. If anyone wants me to add some kind of special parameter checking for this based on the selected highlighter, let me know.