Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI encode the cursorMark value before use #166

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

flawless2011
Copy link
Contributor

URI encoding needed because cursorMark raw value can contain characters not allowed without uri encoding. Closes #165

URI encoding needed because cursorMark raw value can contain characters not allowed without uri encoding
nicolasembleton added a commit that referenced this pull request Dec 4, 2015
URI encode the cursorMark value before use
@nicolasembleton nicolasembleton merged commit 1a684ef into lbdremy:master Dec 4, 2015
@nicolasembleton
Copy link
Collaborator

Nice catch. Thanks @flawless2011

@flawless2011
Copy link
Contributor Author

No problem. Any chance we can get a 0.6.1 release out to npm @nicolasembleton ?

@nicolasembleton
Copy link
Collaborator

Yes. Let me work that out. Been away for a while but need to get back at it seriously. Let's try to get one done within the coming 2 weeks. Will create a separate thread.

@flawless2011
Copy link
Contributor Author

@nicolasembleton Any update on pushing a 0.6.1 to npm registry?

@nicolasembleton
Copy link
Collaborator

Lunar new year slowed me down. Will try to consolidate and push this week
(also have some updates to do to the Doc if anyone wants to help there)

On Fri, Jan 29, 2016 at 1:42 AM Derek Lawless notifications@github.com
wrote:

@nicolasembleton https://github.com/nicolasembleton Any update on
pushing a 0.6.1 to npm registry?


Reply to this email directly or view it on GitHub
#166 (comment)
.

@flawless2011
Copy link
Contributor Author

Do you have an open issue on the doc updates?

@nicolasembleton
Copy link
Collaborator

Not yet. Want to participate? If yes I'll make one to make it easier to
know what to document.

On Tue, Feb 2, 2016 at 4:30 AM Derek Lawless notifications@github.com
wrote:

Do you have an open issue on the doc updates?


Reply to this email directly or view it on GitHub
#166 (comment)
.

@flawless2011
Copy link
Contributor Author

I'll do what I can to contribute.

@nicolasembleton
Copy link
Collaborator

Thanks Derek.

On Tue, Feb 2, 2016 at 11:55 PM Derek Lawless notifications@github.com
wrote:

I'll do what I can to contribute.


Reply to this email directly or view it on GitHub
#166 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants