Docker-based tests run via GitHub Actions #233
Conversation
GitHub Actions CI
| version: '3' | ||
| services: | ||
| solr: | ||
| image: solr:5.5.5 |
There was a problem hiding this comment.
Wanted to get it running on the closest version to what we were running it before, and start upgrading later.
| https = require('https'), | ||
| SolrError = require('./error/solr-error'), | ||
| JSONbig = require('json-bigint'); | ||
|
|
There was a problem hiding this comment.
extracted part of solr.js so that it could be reused elsewhere (in my cases, in schemaHelper)
| @@ -3,6 +3,6 @@ | |||
| "host": "127.0.0.1", | |||
| "port": 8983, | |||
| "path": "/solr", | |||
| "core": null | |||
| "core": "testcore" | |||
There was a problem hiding this comment.
It was failing on a newer Solr with 404 error, but worked after I added explicit core. Since this doesn't affect lib implementation per se, this isn't a breaking change.
|
|
||
| describe('Client#createQuery',function(){ | ||
|
|
||
| before((cb) => { |
There was a problem hiding this comment.
since we can't easily load schema.xml into Docker-based Solr, create necessary fields by hand.
|
I'm going to merge this request and several subsequent non-controversial ones to keep the momentum going, but please feel free to post your comments and requests for changes retroactively, I'd be happy to address them at any point. |
Replaced Travis CI with GitHub Actions, as they are faster, more convenient and more reliable.
fixes #232