Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single level of abstraction / Better separation of concerns in query methods #280

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Single level of abstraction / Better separation of concerns in query methods #280

merged 5 commits into from
Aug 30, 2021

Commits on Aug 30, 2021

  1. Rename get to doQuery, because get is a misleading name.

    @rudolfbyker
    rudolfbyker committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    a820453 View commit details
    Browse the repository at this point in the history

  2. Include wt: 'json' in the stringify argument, rather than appending… 

    … it as a string.
    @rudolfbyker
    rudolfbyker committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    3258a95 View commit details
    Browse the repository at this point in the history

  3. Rename options to queryParameters in the update method.

    @rudolfbyker
    rudolfbyker committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    12ae657 View commit details
    Browse the repository at this point in the history

  4. Extract private method getFullHandlerPath.

    @rudolfbyker
    rudolfbyker committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    53c182c View commit details
    Browse the repository at this point in the history

  5. Better separation of concerns: Separate functions for doQuery and `… 

    …doRequest` rather than separate functions for `get` and `post` (which did almost exactly the same thing).
    @rudolfbyker
    rudolfbyker committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    5531fb5 View commit details
    Browse the repository at this point in the history